There appears to be an inconsistency in how the external job source tag key is defined. The current definition:

EXTERNAL_JOB_SOURCE_TAG_KEY = f"{SYSTEM_TAG_PREFIX}external_job_source"

Since SYSTEM_TAG_PREFIX is defined as "dagster/" (with a trailing slash), this would create a tag key of "dagster/external_job_source".

However, in the frontend code's isExternalRun() function, it's looking for a tag key named "dagster/external_job_source".

This definition is correct, but it's worth noting that there was a duplicate definition later in the file (now removed) that had a different format with a hyphen:

EXTERNAL_JOB_SOURCE_TAG_KEY = f"{SYSTEM_TAG_PREFIX}/external-job-source"

This would have created a tag key of "dagster//external-job-source" with a double slash and hyphens instead of underscores.

The current implementation is correct, but it's important to ensure consistency in tag naming conventions throughout the codebase.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.

The dependency array includes the entire options object, which can lead to unnecessary re-renders since objects are compared by reference. Consider using only the specific property needed for comparison:

useEffect(() => {
  if (isExternal !== options.isExternal) {
    setOptions({...options, isExternal});
  }
  return () => {};
}, [isExternal, options.isExternal]);

This ensures the effect only runs when the actual values being compared change.

Spotted by Diamond

Is this helpful? React 👍 or 👎 to let us know.